[PATCH] D14198: Make the modernize-loop-convert's const-detection smarter.

[Angel Garcia via cfe-commits]

angelgarcia added a comment.

> Reading just this function, it is unclear what the 'container' is.


It should be clearer now.

> Can't CaptureBuRef be modified?


I added a comment with an explanation.

> But they are aliases. Shouldn't we then go into the const-ness of the


aliases?
I wanted to test that if we take a non-const reference, we recognize that
it is a non-const usage. But if we only do it once, the check handles it
differently because it moves that declaration to the loop's statement. I
added a few tests with this particular case as well (they don't harm).

In the case of const-references, we don't need to go through their usages
to know that they won't be modified. If the reference is non-const, even if
it is used in a const way, I don't think we should do anything about it.
That would only make things more complicated: first, we would need to
traverse the subtree again looking for usages of the reference; then, if we
decide that it is not modified and we take a const-reference of the
container's element, we should also change the declaration of the reference
to make it const.


http://reviews.llvm.org/D14198