[PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

Martell Malone via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 29 09:18:29 PDT 2015


martell created this revision.
martell added a reviewer: rnk.
martell added a subscriber: cfe-commits.

GCC versions starting at 4.8+ conform to standard Windows 64-bit ABI.
Not quite sure if we should keep this to support mingw-w64 and gcc 4.6
Thoughts ?

Also it seems to fix:
https://llvm.org/bugs/show_bug.cgi?id=24408&list_id=75541

Thanks to awson for the tip

http://reviews.llvm.org/D14179

Files:
  lib/CodeGen/TargetInfo.cpp

Index: lib/CodeGen/TargetInfo.cpp
===================================================================
--- lib/CodeGen/TargetInfo.cpp
+++ lib/CodeGen/TargetInfo.cpp
@@ -3333,10 +3333,6 @@
     if (RT->getDecl()->hasFlexibleArrayMember())
       return getNaturalAlignIndirect(Ty, /*ByVal=*/false);

-    // FIXME: mingw-w64-gcc emits 128-bit struct as i128
-    if (Width == 128 && IsMingw64)
-      return ABIArgInfo::getDirect(
-          llvm::IntegerType::get(getVMContext(), Width));
   }

   // vectorcall adds the concept of a homogenous vector aggregate, similar to


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14179.38744.patch
Type: text/x-patch
Size: 573 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151029/d612e51f/attachment.bin>


More information about the cfe-commits mailing list