[PATCH] D13874: Atomics: support __c11_* calls on _Atomic struct types

Saleem Abdulrasool via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 19:49:53 PDT 2015


compnerd added a subscriber: compnerd.
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
This revision is now accepted and ready to land.

================
Comment at: lib/CodeGen/CGAtomic.cpp:782
@@ +781,3 @@
+  LValue AtomicVal = MakeAddrLValue(Ptr, AtomicTy);
+  AtomicInfo Atomics(*this, AtomicVal);
+
----------------
s/Atomics/AI/?  Or perhaps Atomic?

================
Comment at: lib/CodeGen/CGAtomic.cpp:1021
@@ -1010,1 +1020,3 @@
+          ResVal,
+          Builder.CreateBitCast(Dest, ResVal->getType()->getPointerTo()));
     }
----------------
It feels like it might be nice to hoist the `CreateBitCast`.


Repository:
  rL LLVM

http://reviews.llvm.org/D13874





More information about the cfe-commits mailing list