[PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 17:49:11 PDT 2015

alexfh accepted this revision.
alexfh added a comment.

In http://reviews.llvm.org/D7639#276641, @LegalizeAdulthood wrote:

> I mean, look at this review.  I created it on Feb 13th 2015.  It's been getting ground through the review process for 8 months.  Why can't we move forward?

Yes, I know the long reviews may be annoying. And I apologize for missing the latest updates on this patch from June. Please feel free to ping the reviews when there are no updates on them for a few days.

There are still a few comments on this patch that were not completely addressed, but it seems fine to submit the patch at this stage and address the concerns after the patch is in.

I'll commit the patch for you.

Comment at: clang-tidy/readability/RedundantVoidArgCheck.cpp:51
@@ +50,3 @@
+                                  unless(isImplicit()),
+                                  unless(isExternC())).bind(FunctionId),
+                     this);
I'm pretty sure the lexer is able to work on header files, if used correctly. If you need help figuring out what's wrong, please provide more information: which assert fails, call stack, and a reduced test case where the assert fails.


More information about the cfe-commits mailing list