[PATCH] D13304: Avoid inlining in throw statement

Jun Bum Lim via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 16:42:31 PDT 2015

junbuml added a comment.

I see what you mean. Now, I doubt if BranchProbabilityInfo::calcColdCallHeuristics() set  the Cold  before inliner. As far as I check, BranchProbabilityInfo is executed after inliner.

Another issue is that even if we can add the Cold in callsites in exception handling regions before inliner, the default ColdThreshold (225) in the inliner is still not tuned (r200898), so I cannot see the expected performance improvement only with the Cold.

If we don't have any plan to tune the ColdThreshold in near future, we may need to use other ways to conservatively inline in exception handling regions. So, for example, in this patch I simply added both Cold and NoInline.


More information about the cfe-commits mailing list