[PATCH] D13304: Avoid inlining in throw statement

hfinkel@anl.gov via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 14:03:06 PDT 2015

hfinkel added a comment.

In http://reviews.llvm.org/D13304#269049, @junbuml wrote:

> I just want to ping one more time to see if there is any objection about the basic idea of this change. If the basic idea itself is acceptable, then I want to find the best way to get idea in.
> Please let me know any new suggestion or any opinion about moving this implementation back to backend (maybe in PrunceEH.cpp) with the minimum callee size check to avoid blindly marking noinlines on all callsites. I will be happy to hear any opinion.

It seems like we want two things here:

1. Mark the exception-handling intrinsics as cold
2. Have the inliner not inline things in cold regions

What is preventing us from doing this now?


More information about the cfe-commits mailing list