[PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

Renato Golin via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 11:19:26 PDT 2015

On 27 October 2015 at 18:15, Tim Northover via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> It sets the underlying platform to a Darwin one so that -arch armv7 flag
> works as expected.

Still looks weird. I don't think this should work at all, as in, the
driver should emit an error like "no such arch". But that's not
relevant here. :)

> Either way, I think the patch as it is now is fine, but we'd need to be
> careful if we wanted to remove the TY_PP_Asm check.

I think Alexandros got that one right already in his new revision, but
we need to make sure he actually did.

That's why I mentioned to duplicate the tests for EABI and Darwin
(possibly Linux, too?). But would be good if you could double check
the odd examples, too, so that he can add to the tests.


More information about the cfe-commits mailing list