[PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

Tim Northover via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 27 09:07:00 PDT 2015

t.p.northover added a subscriber: t.p.northover.
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.

This looks mostly fine, just one quick question that shouldn't block anything:

Comment at: test/Driver/arm-ias-Wa.s:67
@@ +66,3 @@
+// ========================================================== Triple
+// RUN: %clang -target armv7a-arm-none-eabi -c %s -### 2>&1 \
+// RUN:   | FileCheck -check-prefix=CHECK-A-PROFILE %s
Is the -arm- vendor intentional (because DS-5 uses that or something)? Fine if so (it could probably do with being tested actually), a bit weird otherwise.


More information about the cfe-commits mailing list