[PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy
Samuel Benzaquen via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 26 13:07:46 PDT 2015
sbenza added a comment.
Just fyi, I am looking at this diff. It is very large with a lot of rounds of comments and I didn't have the context.
I don't know if I should giving comments at this point of the change, but here it is.
Have you considered matching on typeLoc() instead of having a large list of different cases?
For example, if you match `typeLoc(loc(functionType()))` it will match all the places where a function type is mentioned, including things like `static_cast<XXX>`, variable declarations, lambda return type declarations, etc. Might help remove redundancy in the check.
More information about the cfe-commits