[PATCH] D14014: Checker of proper vfork usage

Aleksei Sidorin via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 24 08:57:09 PDT 2015

a.sidorin added inline comments.

Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:47
@@ +46,3 @@
+  bool isChildProcess(const ProgramStateRef State) const;
ygribov wrote:
> a.sidorin wrote:
> > I think it's a good idea to make some functions static and/or move them out of class definition.
> Right. Which one is preferred btw?
isChildProcess(), getAssignedVariable() are good candidates since they don't use any class member.



More information about the cfe-commits mailing list