[PATCH] D13978: [X86] Support MCU psABI when marking inregs

David Kreitzer via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 22 08:56:59 PDT 2015

DavidKreitzer added inline comments.

Comment at: lib/CodeGen/TargetInfo.cpp:1239
@@ +1238,3 @@
+    // The MCU psABI allows passing parameters in-reg even if there are
+    // earlier, parameters that are passed on the stack. Also,
+    // it does not allow passing >8-byte structs in-register,
Minor nit - you don't need the comma after "earlier".

Comment at: test/CodeGen/x86_32-arguments-iamcu.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -w -triple i386-pc-elfiamcu -mfloat-abi soft -emit-llvm -o - %s | FileCheck %s
Good test!

I think it would be a good idea to add a varargs function & verify that the args do not get marked inreg.


More information about the cfe-commits mailing list