r250803 - Put back dead code that's used out-of-tree.

[David Blaikie via cfe-commits]

Nevermind, I see this was floated/discussed in the review thread of the
original commit ( 250418  )

On Tue, Oct 20, 2015 at 11:46 AM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
> On Tue, Oct 20, 2015 at 12:50 AM, Benjamin Kramer via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
>
>> Author: d0k
>> Date: Tue Oct 20 02:50:21 2015
>> New Revision: 250803
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=250803&view=rev
>> Log:
>> Put back dead code that's used out-of-tree.
>>
>
> Might be worth adding some unit tests (& comments there to give people
> some idea about it)?
>
>
>>
>> Partially reverts r250418.
>>
>> Modified:
>>     cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp
>>     cfe/trunk/lib/Tooling/Core/CMakeLists.txt
>>     cfe/trunk/unittests/Tooling/CMakeLists.txt
>>
>> Modified: cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp?rev=250803&r1=250802&r2=250803&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp (original)
>> +++ cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp Tue Oct 20 02:50:21 2015
>> @@ -36,3 +36,33 @@ CodeGenABITypes::CodeGenABITypes(ASTCont
>>  // Explicitly out-of-line because ~CodeGenModule() is private but
>>  // CodeGenABITypes.h is part of clang's API.
>>  CodeGenABITypes::~CodeGenABITypes() = default;
>> +
>> +const CGFunctionInfo &
>> +CodeGenABITypes::arrangeObjCMessageSendSignature(const ObjCMethodDecl
>> *MD,
>> +                                                 QualType receiverType) {
>> +  return CGM->getTypes().arrangeObjCMessageSendSignature(MD,
>> receiverType);
>> +}
>> +
>> +const CGFunctionInfo &
>> +CodeGenABITypes::arrangeFreeFunctionType(CanQual<FunctionProtoType> Ty) {
>> +  return CGM->getTypes().arrangeFreeFunctionType(Ty);
>> +}
>> +
>> +const CGFunctionInfo &
>> +CodeGenABITypes::arrangeFreeFunctionType(CanQual<FunctionNoProtoType>
>> Ty) {
>> +  return CGM->getTypes().arrangeFreeFunctionType(Ty);
>> +}
>> +
>> +const CGFunctionInfo &
>> +CodeGenABITypes::arrangeCXXMethodType(const CXXRecordDecl *RD,
>> +                                      const FunctionProtoType *FTP) {
>> +  return CGM->getTypes().arrangeCXXMethodType(RD, FTP);
>> +}
>> +
>> +const CGFunctionInfo &CodeGenABITypes::arrangeFreeFunctionCall(
>> +    CanQualType returnType, ArrayRef<CanQualType> argTypes,
>> +    FunctionType::ExtInfo info, RequiredArgs args) {
>> +  return CGM->getTypes().arrangeLLVMFunctionInfo(
>> +      returnType, /*IsInstanceMethod=*/false, /*IsChainCall=*/false,
>> argTypes,
>> +      info, args);
>> +}
>>
>> Modified: cfe/trunk/lib/Tooling/Core/CMakeLists.txt
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Core/CMakeLists.txt?rev=250803&r1=250802&r2=250803&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Tooling/Core/CMakeLists.txt (original)
>> +++ cfe/trunk/lib/Tooling/Core/CMakeLists.txt Tue Oct 20 02:50:21 2015
>> @@ -1,6 +1,7 @@
>>  set(LLVM_LINK_COMPONENTS support)
>>
>>  add_clang_library(clangToolingCore
>> +  Lookup.cpp
>>    Replacement.cpp
>>
>>    LINK_LIBS
>>
>> Modified: cfe/trunk/unittests/Tooling/CMakeLists.txt
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/CMakeLists.txt?rev=250803&r1=250802&r2=250803&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/unittests/Tooling/CMakeLists.txt (original)
>> +++ cfe/trunk/unittests/Tooling/CMakeLists.txt Tue Oct 20 02:50:21 2015
>> @@ -6,6 +6,7 @@ set(LLVM_LINK_COMPONENTS
>>  add_clang_unittest(ToolingTests
>>    CommentHandlerTest.cpp
>>    CompilationDatabaseTest.cpp
>> +  LookupTest.cpp
>>    ToolingTest.cpp
>>    RecursiveASTVisitorTest.cpp
>>    RecursiveASTVisitorTestCallVisitor.cpp
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151020/25ac842d/attachment.html>