[PATCH] D13482: Revised Initial patch for PS4 toolchain

Romanova, Katya via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 13 18:22:49 PDT 2015


Sorry for causing the trouble with the build. I will try to look later why my partial rebuild didn't catch the issue.
I have fixed the error, rebuilt and ran the tests.

This is a very big patch. Please be understanding, because this patch has a big impact. I apologize in advance if it causes some other problems in the future.

Katya.

> -----Original Message-----
> From: Ed Maste [mailto:emaste at freebsd.org]
> Sent: Tuesday, October 13, 2015 5:13 PM
> To: Romanova, Katya; alexr at leftfield.org; Robinson, Paul;
> echristo at gmail.com; filcab+llvm.phabricator at gmail.com;
> jonathan at codesourcery.com
> Cc: emaste at freebsd.org; Bedwell, Greg; pierregousseau14 at gmail.com;
> anton at korobeynikov.info; geek4civic at gmail.com; cfe-
> commits at lists.llvm.org; chisophugis at gmail.com
> Subject: Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain
> 
> emaste added a subscriber: emaste.
> 
> ================
> Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:4080
> @@ +4079,3 @@
> +  SmallString<512> PS4SDKDir;
> +  if (const char *EnvValue = getenv("SCE_PS4_SDK_DIR"))
> +    if (!llvm::sys::fs::exists(EnvValue))
> ----------------
> Looks like a missing { here
> 
> 
> Repository:
>   rL LLVM
> 
> http://reviews.llvm.org/D13482
> 
> 



More information about the cfe-commits mailing list