[PATCH] D13673: Add initial support for the MUSL C library.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 13 15:30:59 PDT 2015


EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

I don't think this is ready to go. Please don't commit yet. Sorry @jroelofs.


================
Comment at: CMakeLists.txt:309
@@ -307,1 +308,3 @@
 
+config_define_if(LIBCXX_LIBC_IS_MUSL _LIBCXX_LIBC_IS_MUSL)
+
----------------
Please name the macro "_LIBCPP_HAS_MUSL_LIBC" for consistency. 

================
Comment at: include/__config:370
@@ -369,2 +369,3 @@
 #elif defined(__linux__)
-#include <features.h>
+#if defined(__GLIBC__)
+# include <features.h>
----------------
Where does the `__GLIBC__`  macro definition come from? I thought it came from the C library headers but we don't include any!


http://reviews.llvm.org/D13673





More information about the cfe-commits mailing list