[PATCH] D13482: Revised Initial patch for PS4 toolchain

[Eric Christopher via cfe-commits]

(Jonathan's review here is fine, don't wait on me. Thanks! :)

-eric

On Tue, Oct 13, 2015 at 10:32 AM Jonathan Roelofs <jonathan at codesourcery.com>
wrote:

> jroelofs added a comment.
>
> Other than that, LGTM too.
>
>
> ================
> Comment at: lib/Driver/ToolChains.cpp:4081
> @@ +4080,3 @@
> +
> +  std::string PS4SDKDir = (EnvValue ? EnvValue : getDriver().Dir +
> "/../..");
> +
> ----------------
> Use `llvm::sys::path::append` instead of `std::string::operator+` for path
> concatenation here,
>
> ================
> Comment at: lib/Driver/ToolChains.cpp:4095
> @@ +4094,3 @@
> +
> +  std::string PS4SDKIncludeDir = PrefixDir + "/target/include";
> +  if (!Args.hasArg(options::OPT_nostdinc) &&
> ----------------
> and here,
>
> ================
> Comment at: lib/Driver/ToolChains.cpp:4105
> @@ +4104,3 @@
> +
> +  std::string PS4SDKLibDir = PS4SDKDir + "/target/lib";
> +  if (!Args.hasArg(options::OPT_nostdlib) &&
> ----------------
> and here.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D13482
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151013/82fc75b3/attachment.html>