[PATCH] D12686: Add support for GCC's '__auto_type' extension.

[Richard Smith via cfe-commits]

rsmith added a comment.

Thanks, this essentially looks good to me. I can't think of any other cases where C++ allows `auto` that you've not covered.


================
Comment at: lib/Sema/SemaExprCXX.cpp:1172-1173
@@ -1171,1 +1171,4 @@
 
+  if (D.getDeclSpec().getTypeSpecType() == DeclSpec::TST_auto_type)
+      return ExprError(Diag(StartLoc, diag::err_new_auto_type));
+
----------------
How about instead handling this...

================
Comment at: lib/Sema/SemaType.cpp:2687
@@ -2682,3 +2686,3 @@
     case Declarator::ConditionContext:
     case Declarator::CXXNewContext:
       break;
----------------
... here.


http://reviews.llvm.org/D12686