[PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

Nathan Wilson via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 12 06:33:06 PDT 2015


nwilson marked 2 inline comments as done.

================
Comment at: lib/Sema/SemaDecl.cpp:7886
@@ -7863,1 +7885,3 @@
+
+      if (NewFD->isInvalidDecl() && !NewFD->isConcept()) {
         HasExplicitTemplateArgs = false;
----------------
Maybe there could be a problem further down if we think there aren't explicit template args and there really are. We could do a check similar to the isFriend check in the same block below like this:

else if (isConcept && isFunctionTemplateSpecialization) {
  HasExplicitTemplateArgs = true;
}

But it seems like that's essentially the same thing. 




http://reviews.llvm.org/D13357





More information about the cfe-commits mailing list