[PATCH] D13549: Added new options to ClangFormat VSIX package.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 12 01:47:21 PDT 2015


klimek added inline comments.

================
Comment at: tools/clang-format/ClangFormat.cpp:227
@@ -213,1 +226,3 @@
+      llvm::outs() << """;
+      break;
     default:
----------------
curdeius wrote:
> klimek wrote:
> > For XML, we should only need "<" and "&". Everything else is just important in a context introduced by "<" or "&".
> > The problem with include-sorting is that we'll now need to fully support utf8 input (well, any encoding, to be precise).
> > The best way is probably to escape all code points that are outside the ascii range. The problem I see is that we have no idea what encoding the file is in, so I have no clue how we can really resolve this.
> > 
> Ok. I'll cut it  down to the necessary minimum ('<', '&').
> Anyway, I thing it's more urgent to fix the include sorting containing open brackets and later work on UTF-8 support.
Agreed. Can you please add a FIXME though:
// FIXME: When we sort includes, we need to make sure the stream is correct
// utf-8.


http://reviews.llvm.org/D13549





More information about the cfe-commits mailing list