[PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

[Aaron Ballman via cfe-commits]

On Fri, Oct 9, 2015 at 3:09 PM, Daniel Berlin <dberlin at dberlin.org> wrote:
> dberlin added a subscriber: dberlin.
>
> ================
> Comment at: docs/clang-tidy/checks/cert-variadic-function-def.rst:13
> @@ +12,2 @@
> +`DCL50-CPP. Do not define a C-style variadic function
> +<https://www.securecoding.cert.org/confluence/display/cplusplus/DCL50-CPP.+Do+not+define+a+C-style+variadic+function>`_.
> ----------------
> I'm sure this is oversight on CERT's part, but their website actually has terms of use (click the terms of use at the bottom of the page) that says this can't be copied/reused, and here you are, copying it.
> It explicit says: "
> Use of the Service. You may only display the content of the Service for your own personal use (i.e., non-commercial use) and may not otherwise copy, reproduce, alter, modify, create derivative works, or publicly display any content. "
>
> Before this is accepted, someone should email cert and say "hey, uh, yeah, this seems bad", and get them to okay you doing this.
> I'm sure they'll go and fix this.

That's an excellent point, I will bring it up internally (I work for
CERT) and report back.

~Aaron

>
>
>
> http://reviews.llvm.org/D13446
>
>
>