[PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

[Anna Zaks via cfe-commits]

zaks.anna added a comment.

> I don't notice any significant performance hit with this 

>  patch (+/- 2% on the whole Android codebase runs).


What did you test it on?

> we're covering all three places that were patched; maybe i could move these tests

>  to symbol-reaper.c as well, but i guess it's more worth it to test the actual analyzer output than 

>  artificially dumped internals(?) Not sure.


I'd add all necessary tests to the symbol-reaper.c and duplicate one of them in return-ptr-range.cpp to see that it has an effect on bug reporting.

> The change in Environment.cpp was removed because it's now handled automatically by markLive().


This patch is different from what I sent. In my patch, I was marking the region as live and your latest patch is marking the indexes live without marking the region in some cases. What are the implications in each case?


================
Comment at: docs/analyzer/DebugChecks.rst:143
@@ +142,3 @@
+
+  Subscribe for a delayed warning when the symbol that represents the value of
+  the argument is garbage-collected by the analyzer.
----------------
What does subscribe mean? How do you decide when to subscribe/start tracking the symbol? Are you supposed to do that when you know the symbol is live?


http://reviews.llvm.org/D12726