[PATCH] D13546: [ATTR] Automatic line feed after pragma-like attribute.

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 8 13:53:20 PDT 2015


ABataev marked 2 inline comments as done.

================
Comment at: lib/AST/DeclPrinter.cpp:197
@@ -196,3 +196,3 @@
 
-void DeclPrinter::prettyPrintAttributes(Decl *D) {
+void DeclPrinter::prettyPrintAttributes(Decl *D, bool PrintPragmas) {
   if (Policy.PolishForDeclaration)
----------------
aaron.ballman wrote:
> Would it make more sense to add a prettyPrintPragmas(Decl *D) function instead?
Ok, will do

================
Comment at: test/SemaCXX/pragma-init_seg.cpp:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -fsyntax-only -verify -fms-extensions %s -triple x86_64-pc-win32
+// RUN: %clang_cc1 -fsyntax-only -verify -fms-extensions %s -triple x86_64-pc-win32 -ast-print | FileCheck %s
 // RUN: %clang_cc1 -fsyntax-only -verify -fms-extensions %s -triple i386-apple-darwin13.3.0
----------------
aaron.ballman wrote:
> I think this should be a new test under Misc\. We have ast-print-pragmas.cpp that looks like a good place for it to go.
Ok


http://reviews.llvm.org/D13546





More information about the cfe-commits mailing list