[PATCH] D13567: [PATCH] Add checker discouraging use of setjmp/longjmp in C++

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 8 12:49:23 PDT 2015


On Thu, Oct 8, 2015 at 3:47 PM, Samuel Benzaquen <sbenza at google.com> wrote:
> sbenza added inline comments.
>
> ================
> Comment at: clang-tidy/cert/SetLongJmpCheck.cpp:31
> @@ +30,3 @@
> +public:
> +  explicit SetJmpMacroCallbacks(Preprocessor *PP, SetLongJmpCheck &Check)
> +      : PP(PP), Check(Check) {}
> ----------------
> Why do you pass one as a pointer and one as a reference?

Bad copy-pasta. I don't even need PP. Good catch! I will remove that.

~Aaron

>
>
> http://reviews.llvm.org/D13567
>
>
>


More information about the cfe-commits mailing list