[PATCH] D13557: Make locale code compile on Linux without GLIBC.

Vasileios Kalintiris via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 8 09:44:10 PDT 2015


vkalintiris abandoned this revision.
vkalintiris added a comment.

In http://reviews.llvm.org/D13557#262801, @jroelofs wrote:

> Unfortunately, Musl intentionally doesn't provide that sort of macro [1], so to provide support for Musl in libc++, we need to make note of it at configure-time via something like a _LIBCXX_LIBC_IS_MUSL macro via http://reviews.llvm.org/D13407.


Agreed. That would be much more elegant. I had to write another patch to test for the existence of *each* extended locale functions during configuration-time. It was generic but an ugly hack. Offering a _LIBCXX_LIBC_IS_MUSL option/macro would make things quite simpler. I'll abandon this review request and I'll wait until http://reviews.llvm.org/D13407 is committed.


http://reviews.llvm.org/D13557





More information about the cfe-commits mailing list