[PATCH] D13482: Revised Initial patch for PS4 toolchain

[Katya Romanova via cfe-commits]

kromanova created this revision.
kromanova added reviewers: filcab, echristo, alexr, probinson.
kromanova added subscribers: silvas, cfe-commits, chapuni, jroelofs, asl, pgousseau, gbedwell.
kromanova set the repository for this revision to rL LLVM.

Initial patch for PS4 toolchain was created here: http://reviews.llvm.org/D11279
When this patch was committed in r248546, it caused 2 distinct problems.

(1) Many failures were reported on recently set up PS4 bot. The PS4 driver intentionally reported warnings if PS4 SDK was missing. The new buildbot didn't have PS4 SDK directory installed. This "combination" caused failures for all the tests that had -Werror option.
(2) ps4-linker-win.c failed on all the Windows bots.

This commit was reverted in r248548 to make the bots green again and to decide on how to deal with missing PS4 SDK directory issue.

The new patch should take care of both problems mentioned above.
Since review for http://reviews.llvm.org/D11279 was owned by Filipe Cabecinhas and already closed, it's probably easier for me to open a new code review. Feel free to compare this new patch to the latest patch in D11279.
Here is the summary of the changes:

1.	include/clang/Basic/DiagnosticDriverKinds.td     
Added DefaultIgnore attribute to InvalidOrNonExistentDirectory. 
By default, the PS4 driver won't report a warning about missing PS4 SDK. This behavior could be changed if  -Weverything or 
-Winvalid-or-nonexistent-directory options are passed.

2.	Changed 
test/Driver/ps4-linker-non-win.c to use -fuse-ld=gold instead of -linker=gold
test/Driver/ps4-linker-win.c to use -fuse-ld=gold instead of -linker=gold
We do not support "-linker" option anymore. Use "-fuse-ld" instead.

3. test/Driver/ps4-sdk-root.c
Added -Winvalid-or-nonexistent-directory to all the RUN lines to force the warning (this is the only test where we want to have the warnings about missing PS4 SDK directory enabled).

4.	test/Driver/rtti-options.cpp 
Removed all the changes. No changes are needed, since the warning is not reported by default anymore.

Origianal patch extracted by Filipe Cabecinhas, me (Katya Romanova), and Pierre Gousseau.






Repository:
  rL LLVM

http://reviews.llvm.org/D13482

Files:
  include/clang/Basic/DiagnosticDriverKinds.td
  include/clang/Basic/DiagnosticGroups.td
  lib/Driver/Driver.cpp
  lib/Driver/ToolChains.cpp
  lib/Driver/ToolChains.h
  lib/Driver/Tools.cpp
  lib/Driver/Tools.h
  lib/Frontend/InitHeaderSearch.cpp
  test/Driver/Inputs/scei-ps4_tree/target/include/.keep
  test/Driver/Inputs/scei-ps4_tree/target/include_common/.keep
  test/Driver/debug-options.c
  test/Driver/ps4-header-search.c
  test/Driver/ps4-linker-non-win.c
  test/Driver/ps4-linker-win.c
  test/Driver/ps4-pic.c
  test/Driver/ps4-sdk-root.c
  test/Driver/stack-protector.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13482.36647.patch
Type: text/x-patch
Size: 39254 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20151006/ba6e162d/attachment-0001.bin>