[PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 6 07:02:25 PDT 2015


klimek added a subscriber: klimek.
klimek added a comment.

In http://reviews.llvm.org/D13368#260669, @aaron.ballman wrote:

> This wasn't a comment on the rule so much as a comment on the diagnostic not being very helpful.In this case, you're telling the user to not do something, but it is unclear how the user would structure their code to silence this diagnostic. Perhaps there is no way to word this to give the user a clue, but we should at least try. If I got this diagnostic as it is now, I would scratch my head and quickly decide to ignore it.


The cpp core guidelines are written in a way that they should be referenceable by links - do we want to add links to the relevant portions of the core guidelines from the clang-tidy checks?


http://reviews.llvm.org/D13368





More information about the cfe-commits mailing list