[PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

David Majnemer via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 1 09:29:58 PDT 2015


majnemer added a subscriber: majnemer.
majnemer added a comment.

In http://reviews.llvm.org/D13203#257539, @klimek wrote:

> Not sure whether it makes sense to work around compiler bugs in CL. I assume this happens with clang from trunk? Is there a bug filed against CL?


We do this with some regularity for MSVC and GCC.


================
Comment at: ASTContext.cpp:367-369
@@ -366,4 +366,5 @@
       OriginalDeclForRC = I;
-      RawCommentAndCacheFlags Raw;
+      RedeclComments[I] = RawCommentAndCacheFlags();
+      RawCommentAndCacheFlags &Raw = RedeclComments[I];
       if (RC) {
         Raw.setRaw(RC);
----------------
We need a comment detailing that this is a workaround for MSVC 2015 so that it can be removed when we drop support for 2015.


http://reviews.llvm.org/D13203





More information about the cfe-commits mailing list