[PATCH] D13342: Prevent loop-convert from leaving empty lines after removing an alias declaration.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 1 05:46:06 PDT 2015


klimek added inline comments.

================
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:455-457
@@ +454,5 @@
+///
+/// FIXME: if 'next_instruction' is a closing brace ('}'), after the replacement
+/// it will be over-indented. But then, who would declare an alias and do
+/// nothing with it before it goes out of the scope?
+void LoopConvertCheck::getAliasRange(SourceManager &SM, SourceRange &Range) {
----------------
Replace this with something like:
We need to delete a potential newline after the deleted alias, as clang-format will leave empty lines untouched. For all other formatting we rely on clang-format to fix it.


http://reviews.llvm.org/D13342





More information about the cfe-commits mailing list