[PATCH] D13100: [mips] Separated mips specific -Wa options, so that they are not checked on other platforms.

Joerg Sonnenberger via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 30 09:17:01 PDT 2015


On Wed, Sep 30, 2015 at 02:19:58PM +0000, Daniel Sanders via cfe-commits wrote:
> Hi,
> 
> Sorry for the slow reply. I'm a bit behind on cfe-commits and it seems I dropped out of the CC list so it didn't land in my inbox.
> 
> Do you mean something like this?:
> 	for (...) {
> 	  ...
> 
> 	  switch (C.getDefaultToolChain().getArch()) {
> 	  default:
> 	    break;
> 	  case llvm::Triple::mips:
> 	  case llvm::Triple::mipsel:
> 	  case llvm::Triple::mips64:
> 	  case llvm::Triple::mips64el:
> 	    if (Value == "--trap") {
> 	      ...
> 	      continue;
> 	    }
> 	    break;
> 	  }
> 	
> 	  if (Value == "-force_cpusubtype_ALL") {
> 	    ...
> 	    continue;
> 	  }
> 
> 	  ...
> 
> 	  D.Diag(diag::err_drv_unsupported_option_argument)
> 	      << A->getOption().getName() << Value;
> 	}
> 
> If so, that sounds good to me.

Correct.

Joerg


More information about the cfe-commits mailing list