[PATCH] D13190: Addition of interfaces the FE to conform to Table A-2 of ELF V2 ABI V1.1

Bill Schmidt via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 28 07:47:05 PDT 2015


wschmidt added a comment.

Other than the FIXME removal, this LGTM!  Very good and careful work.  Thanks for taking care of this!


================
Comment at: lib/Headers/altivec.h:13788
@@ -13416,3 +13787,3 @@
 removed with -mno-crypto). This is under development.
 */
 #ifdef __CRYPTO__
----------------
Please remove the above FIXME, since this has now been taken care of.

================
Comment at: lib/Headers/altivec.h:13832
@@ -13450,2 +13831,3 @@
+((X), (Y), (Z))
 #endif
 
----------------
Nice use of _Generic.  I wasn't aware of this feature.


Repository:
  rL LLVM

http://reviews.llvm.org/D13190





More information about the cfe-commits mailing list