[PATCH] D13166: Create modernize-make-unique check.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 28 07:08:37 PDT 2015


klimek added inline comments.

================
Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:75-76
@@ +74,4 @@
+  std::string Identifier = removeWhitespace(ExprStr.substr(0, LAngle));
+  if (Identifier != "unique_ptr" && Identifier != "std::unique_ptr")
+    return;
+  SourceLocation ConstructCallEnd = ConstructCallStart.getLocWithOffset(LAngle);
----------------
Comment what cases this can happen in, and why we don't want to replace in those cases...


http://reviews.llvm.org/D13166





More information about the cfe-commits mailing list