Bug 23529: Add support for gcc's attribute abi_tag (needed for compatibility with gcc 5's libstdc++)

Stefan Bühler via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 27 05:45:35 PDT 2015


it seems moderation didn't approve the phabricator mails for D12834.
(I have no intention to be subscribed to the list just to get
phabricator mails through. For now I am subscribed but disabled
mail delivery -.-)

So the patch is available at http://reviews.llvm.org/D12834

I also added a test case which shows that substitution is not
working correctly right now.


PS: I think contributing to llvm is way to complex. First I attatch
patches in the bug tracker, and it takes ages to get a reaction - and
them I'm simply told to send to the ML. Then you want me to use
phabricator, and then I get no feedback again - because moderation
blocked emails from an internal system, and it seems nobody is looking
at phabricator directly.
This is not something I look forward to go through again; my
motiviation to contribute further is rather low.

On Sat, 12 Sep 2015 12:36:19 -0700
David Majnemer <david.majnemer at gmail.com> wrote:

> Would you mind sticking abi-tag.patch in phabricator:
> http://llvm.org/docs/Phabricator.html ?
> Your patch is big enough that it would make it a little easier for me
> to review.
> On Sat, Sep 12, 2015 at 7:12 AM, Stefan Bühler via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
> > Hi all,
> >
> > I've been working on #23529.
> >
> > The abi tag mangling implemented by gcc is horrible, but I think my
> > patch covers most of the incompatibilities with gcc5.
> >
> > There might be some bugs with substitutions, although I have to
> > come up with a test case for that to see what gcc does...
> >
> > Test cases comparing gcc and patched clang++:
> > http://files.stbuehler.de/test-itanium-mangle.html
> > (generated with http://files.stbuehler.de/test-itanium-mangle.sh,
> > also attached)

More information about the cfe-commits mailing list