[PATCH] D12793: Three new security overflow builtins with generic argument types

John McCall via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 25 14:28:06 PDT 2015

rjmccall added a comment.

X and Y aren't unreasonable for the operands, although you could also use "left" and "right" (or LHS/RHS), especially since it's significant for subtraction.  R is short for "result" and should be spelled out.  E is presumably short for "encompassing", but that is not immediately obvious even to someone reading your patch; spelling it out wouldn't hurt, or you could at least use a longer abbreviation.

You should also spell out the different *Ty suffixes in some way that differentiates them.  I don't think you actually need the *QTy variables.  The *ITy variables aren't really types and should not be named that way.  *LLVMTy is not unreasonable for the IR types.


More information about the cfe-commits mailing list