[Diffusion] rL248438: Fix loop-convert for trivially copyable types.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 07:15:25 PDT 2015


Yep, as I said, I would love to do that, but it would require significant
effort :(

On Thu, Sep 24, 2015 at 7:03 AM Alexander Kornienko <alexfh at google.com>
wrote:

> Too bad. Making these two kinds of mails go to the same thread is hardly a
> trivial thing. And completely switching commit notifications to Phabricator
> is something not very realistic, I guess (at least, at this point).
>
> Giving up.
>
>
> On Thu, Sep 24, 2015 at 3:24 PM, Manuel Klimek <klimek at google.com> wrote:
>
>> The biggest problem is that those comments don't go on the cfe-commmits
>> thread that gets auto-triggered by commits, and we really want to not add
>> new threads.
>>
>> On Thu, Sep 24, 2015 at 4:28 AM Alexander Kornienko <alexfh at google.com>
>> wrote:
>>
>>> alexfh added inline comments.
>>>
>>> /clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertCheck.cpp:573
>>> test6
>>> /clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertCheck.cpp:509
>>> test5
>>>
>>> Users:
>>>   klimek (Author)
>>>
>>> http://reviews.llvm.org/rL248438
>>>
>>>
>>>
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150924/fe5b0e8d/attachment.html>


More information about the cfe-commits mailing list