[PATCH] D13128: Fix backend crash on multiple close of stdout.

Yaron Keren via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 05:36:41 PDT 2015


yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.

When stdout goes elsewhere the console, the shell creates the the output file (pipe) and will close it when clang terminates so  so why clang should close it at  all ? it did not open it.

Practically, we have been running locally

      Error(false), UseAtomicWrites(false) {
  if (FD < 0 ) {
    ShouldClose = false;
    return;
  }
  if (FD <= STDERR_FILENO)
    ShouldClose = false;

and passing regression tests on Windows 7 and Linux, maybe this is required on other usage scenarios or OS.


http://reviews.llvm.org/D13128





More information about the cfe-commits mailing list