[PATCH] D12379: Fix the bugs in the mapDiagnosticRanges (Still in progress)

Zhengkai Wu via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 23 14:57:29 PDT 2015

zhengkai marked an inline comment as done.

Comment at: lib/Frontend/DiagnosticRenderer.cpp:442
@@ -419,1 +441,3 @@
+static bool checkLocForMacroArgExpansion(SourceLocation Loc,
+                                         const SourceManager &SM,
I have stated that I need to check if all the locations checked fit in the same location in the expansionInfo. So I need the preLoc to store the previous checked location to see if they are the same.

Comment at: lib/Frontend/DiagnosticRenderer.cpp:454
@@ -422,1 +453,3 @@
+                                           const SourceManager &SM,
+                                           SourceLocation Loc) {
   SourceLocation BegLoc = Range.getBegin(), EndLoc = Range.getEnd();
See the comment ahead.


More information about the cfe-commits mailing list