[PATCH] D12571: [Analyzer] Fix assertions in commit r246345 (pr22954).

[pierre gousseau via cfe-commits]

pgousseau updated this revision to Diff 35505.
pgousseau added a comment.

Following Devin's review:

Fix a comment in 'IsFirstBufInBound'.
Remove incorrect assertion expecting 'RegionOffset::getOffset' to only return positives values.
Add test cases for regions having negatives offsets.

Updated a 'RegionOffset' class comment which seemed to suggest that 'RegionOffset::getOffset' could not return negative values.
Added test cases and handling for arrays' regions whose upper boundary can overflow.

Let me know if this is an acceptable change ?

Regards,

Pierre Gousseau


http://reviews.llvm.org/D12571

Files:
  include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
  lib/StaticAnalyzer/Checkers/CStringChecker.cpp
  lib/StaticAnalyzer/Core/RegionStore.cpp
  test/Analysis/pr22954.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12571.35505.patch
Type: text/x-patch
Size: 46919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150923/2b6f9fac/attachment-0001.bin>