[Diffusion] rL248367: clang-format: Add initial #include sorting capabilities.

NAKAMURA Takumi via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 23 03:25:27 PDT 2015


chapuni added subscribers: cfe-commits, chapuni.

/cfe/trunk/lib/Tooling/Core/Replacement.cpp:408 FirstI may be in the end() when SecondI != end(). Then FirstI->getOffset() is invalid.

I suggest to split the loop into
  - FirstI != First.end() && SecondI != Second.end();
  - Tail-merge (either is end())

Users:
  djasper (Author)

http://reviews.llvm.org/rL248367





More information about the cfe-commits mailing list