[PATCH] D13013: [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

Renato Golin via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 22 14:43:49 PDT 2015


rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Apart from the style nitpick, LGTM. Thanks!


================
Comment at: lib/Driver/Tools.cpp:6139
@@ +6138,3 @@
+      ArchKind = llvm::ARM::parseCPUArch(Triple.getARMCPUForArch(Arch));
+  } else
+    ArchKind = llvm::ARM::parseCPUArch(CPU);
----------------
Please, add curly brackets here for the else case.


Repository:
  rL LLVM

http://reviews.llvm.org/D13013





More information about the cfe-commits mailing list