[PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 22 06:56:58 PDT 2015

alexfh added inline comments.

Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:96
@@ +95,3 @@
+void MoveConstructorInitCheck::handleMoveConstructor(
+    const MatchFinder::MatchResult &Result) {
Other checks have separate options for the include style (see `PassByValueCheck.cpp`, for example), so this one should have its own option too. If we ever decide to introduce a common option instead, it will be easier to do this, if all usages of the `IncludeInserter` do the same thing with the include style.

One thing I would change though, is to add the IncludeStyle <-> string conversion functions instead of doing this in each check.


More information about the cfe-commits mailing list