[PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

Evgeny Astigeevich via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 21 09:03:47 PDT 2015


eastig added a comment.

In http://reviews.llvm.org/D12689#249899, @rnk wrote:

> I think you need to address the feedback about avoiding dynamic
>  initialization on stock non-Mac systems.
>
> Sent from phone


In my comment above I proposed a special macro to distinguish between dynamic and static linking:

> In the patch the `__APPLE__` macro is used to have the old behaviour. Maybe instead of it another macro, e.g. `__STATIC_BUILD__`, can be use when we want to build a static library.


Is it good to have such a macro?


http://reviews.llvm.org/D12689





More information about the cfe-commits mailing list