[PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Anna Zaks via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 17 18:13:25 PDT 2015


zaks.anna added a comment.

> > It's more user friendly to report this issue at the last point where the request is available rather than the last line of the function.

> 

> >  This looks similar to leak report checking. Is it?

> 

> 

> Yes, that's not very common but possible.

>  Does this change involve the use of a BugReporterVisitor?!


You should register/report the diagnostic at check::DeadSymbols event instead of check:: EndFunction; that way the error will be reported earlier.

> You're right, it's very similar.





http://reviews.llvm.org/D12761





More information about the cfe-commits mailing list