[PATCH] D12933: Add a test to modernize-loop-convert.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 17 07:25:20 PDT 2015


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG with a comment.


================
Comment at: test/clang-tidy/modernize-loop-convert-extra.cpp:705
@@ -704,16 +704,3 @@
 
-  // FIXME: Right now, clang-tidy does not allow to make insertions in several
-  // arguments of the same macro call. The following code:
-  // \code
-  //   for (int i = 0; i < N; ++i) {
-  //    TWO_PARAM(arr[i], arr[i]);
-  //    THREE_PARAM(arr[i], arr[i], arr[i]);
-  //   }
-  // \endcode
-  // Should be converted to this:
-  // \code
-  //   for (auto & elem : arr) {
-  //    TWO_PARAM(elem, elem);
-  //    THREE_PARAM(elem, elem, elem);
-  //   }
-  // \endcode
+  // Multiple arguments.
+  for (int i = 0; i < N; ++i) {
----------------
"Multiple macro arguments." would be clearer.


http://reviews.llvm.org/D12933





More information about the cfe-commits mailing list