[PATCH] D12832: [Driver] Added support for Windows 10 SDK

David Majnemer via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 16 19:57:55 PDT 2015


majnemer added a subscriber: majnemer.

================
Comment at: cfe/trunk/lib/Driver/MSVCToolChain.cpp:263
@@ +262,3 @@
+  std::sscanf(RegistrySDKVersion.c_str(), "v%d.", &Major);
+  if (Major > 7 && Major < 10) {
+    // Windows SDK 8.x installs libraries in a folder whose names depend on the
----------------
Isn't this just `Major == 8 || Major == 9` ?

================
Comment at: cfe/trunk/lib/Driver/MSVCToolChain.cpp:278-279
@@ +277,4 @@
+      return false;
+  }
+  else {
+    if (!getWindows10SDKVersion(Path, WindowsSDKIncludeVersion))
----------------
Same line please.


http://reviews.llvm.org/D12832





More information about the cfe-commits mailing list