[PATCH][Solaris] Default to -fno-cxa-finalize

Xan López via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 15 03:41:05 PDT 2015


On Mon, Sep 14, 2015 at 07:24:11PM -0400, Rafael Espíndola wrote:
> From the driver point of view, how does it know if it is targeting
> illumos or solaris? Do they use different triples?

At this point, they do not, se we can't.

> 
> In any case, if there is interest in the future this patch can be
> extended to work on illumos by
> 
> * Creating a shouldUseCxaAtexitByDefault and passing in whatever
> information is needed (Triple, a IsIlumos flag, etc)
> * Using it instead of the long boolean expression we have right now.
> 
> For now I committed this as r247634.

This sounds good. I'll try to contact the people at Illumos interested
in this to see if they want to work with me on making that happen.

Thanks!

> 
> Cheers,
> Rafael
> 
> 
> 
> On 8 September 2015 at 09:47, Xan López via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
> > On Tue, Sep 08, 2015 at 03:28:12PM +0200, Joerg Sonnenberger via cfe-commits wro> We don't distinguish Solaris and OpenSolaris forks currently. As such,
> >> changing one for the other is not a good choice, especially since you
> >> are more likely to find clang users for Illumos, IMO.
> >>
> >> https://www.illumos.org/issues/3849
> >
> > Well I'm still a bit confused about what were they using exactly,
> > since I'm pretty sure clang has never worked in its upstream form in a
> > general way from 2012/3. As I said maybe they ship a branch of their
> > own or something, not sure.
> >
> > In any case Solaris is not Illumos, so we still need a
> > solution. Should we add a way to distinguish between them and disable
> > this feature only for Sun/Oracle Solaris? If they are diverging in
> > things like this it seems sooner or later it would be needed anyway.
> >
> > Xan
> >
> >>
> >> Joerg
> >> _______________________________________________
> >> cfe-commits mailing list
> >> cfe-commits at lists.llvm.org
> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list