[PATCH] D12855: [OpenCL] Add new types for OpenCL 2.0.

Alexey Bader via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 15 02:17:11 PDT 2015


bader added a comment.

In http://reviews.llvm.org/D12855#246004, @pekka.jaaskelainen wrote:

> The patch seems straightforward enough. BTW does someone know if anyone has worked on the 'pipe' qualifier?


I'm currently supporting Intel's implementation of 'pipe' qualifier and I'd like to contribute this implementation to the community if there is any interest.


================
Comment at: lib/Serialization/ASTCommon.cpp:70
@@ -69,1 +69,3 @@
   case BuiltinType::OCLImage2dArray:  ID = PREDEF_TYPE_IMAGE2D_ARR_ID;  break;
+  case BuiltinType::OCLImage2dDepth:
+    ID = PREDEF_TYPE_IMAGE2D_DEP_ID;
----------------
pekka.jaaskelainen wrote:
> A nitpick, but why deviate from the style where each case has been stuffed to a single line?
My guess it's effect of clang-format. Original patch sent by Pedro matched the style, but violated 80-character limit, so he was asked to run clang-format over the patch. Do you want me to run clang-format on surrounding code to unify the style?


http://reviews.llvm.org/D12855





More information about the cfe-commits mailing list