[PATCH] D12734: Another patch for modernize-loop-convert.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 11 02:06:21 PDT 2015


klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D12734#243157, @angelgarcia wrote:

> Comment the enumerators.
>
> > Do we need default?
>
>
> I think so. We need to set the cases that do not fall in any of these categories to something, and I think that using one of the other three as the default kind would be confusing. But maybe there is a better name than just UK_Default. Any ideas?


Can we perhaps just add a couple of example of other cases that are not member expressions? With that, LG.


http://reviews.llvm.org/D12734





More information about the cfe-commits mailing list