[PATCH] D11815: Pass subtarget feature "force-align-stack"

hfinkel@anl.gov via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 9 22:43:02 PDT 2015


hfinkel added a comment.

In http://reviews.llvm.org/D11815#242616, @ahatanak wrote:

> Hal, do you have any thoughts on the points Vasileios brought up? Currently, many of the targets don't guarantee that the realigned stack is at least as aligned as the default alignment required by the ABI. Is this the behavior end-users expect when they use -mstackrealign on the command line?


I don't think this is expected behavior, and sounds like a bug.

> Fixing this is beyond the initial scope of this patch and probably should be done in a separate patch, but I want to make sure the patch I'll end up committing won't make it harder to fix this problem.


Agreed. I don't see how this makes it harder.


http://reviews.llvm.org/D11815





More information about the cfe-commits mailing list