[PATCH] D12673: [analyzer] Remove whitespace in source code

Honggyu Kim via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 7 18:25:13 PDT 2015


honggyu.kim added a comment.

In http://reviews.llvm.org/D12673#241100, @dblaikie wrote:

> We generally don't do large whitespace changes like this because of issue
>  with version control (not all told are whitespace ignorant which makes
>  history work difficult).


I agree that it would be difficult to trace the history of svn or git.
But I wrote this patch because it would be better to have cleaner source code.
If we don't make whitespace in the future changes, it would be okay to trace the history in the long term.

> I don't mind these changes personally, but it should get sign of from Ted

>  or similar first.


I know it can be just a matter of preference, so someone who is in charge of this code can make decision.
I'm also okay if they don't accept this patch.
Thanks for the comment.


http://reviews.llvm.org/D12673





More information about the cfe-commits mailing list