[PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

Dan Albert via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 5 12:29:40 PDT 2015


Android has posix_memalign too.
On Sep 5, 2015 12:00, "Joerg Sonnenberger" <joerg at britannica.bec.de> wrote:

> On Fri, Sep 04, 2015 at 09:28:39PM +0000, Eric Fiselier via cfe-commits
> wrote:
> > EricWF added a comment.
> >
> > In http://reviews.llvm.org/D12512#237175, @joerg wrote:
> >
> > > Please don't commit this as is. Many platforms have posix_memalign or
> equivalent, which makes this both simpler and potentially without wasting
> memory. Compare e.g. http://reviews.llvm.org/D12001.
> >
> >
> > Will do. Any advice on detecting posix_memalign? I don't see anything in
> the patch you pointed me to.
>
> Provide a feature variable for it and set it by default. For Unix-like
> systems, I think only Android wants to disable it by default. Not sure
> about Windows and OSX.
>
> Joerg
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150905/f20cca5b/attachment.html>


More information about the cfe-commits mailing list