[PATCH] D12631: Avoid repeated replacements on loop-convert check.

[Alexander Kornienko via cfe-commits]

alexfh accepted this revision.
alexfh added a reviewer: alexfh.
alexfh added a comment.
This revision is now accepted and ready to land.

Looks good with a comment.


================
Comment at: clang-tidy/modernize/LoopConvertUtils.h:211
@@ -210,3 +210,3 @@
 /// \brief A class to encapsulate lowering of the tool's confidence level.
 class Confidence {
 public:
----------------
You're right. I missed that getBegin()/getEnd() return values, not const references. Anyway, it's irrelevant now.

================
Comment at: clang-tidy/modernize/LoopConvertUtils.h:280
@@ -279,1 +279,3 @@
 
+  /// \brief Returns true and adds the Usage if it was not added before.
+  void addUsage(const Usage &U);
----------------
The "Returns true" part is wrong now.


http://reviews.llvm.org/D12631